-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrated SPARQL Query; addresses SPARQL-issue-1 #3
Conversation
ce474ea
to
e57ea97
Compare
How we at Professional Wiki typically do dependency injection in MediaWiki extensions:
Ultimately what we are after is well-designed code that is easy to test and understand and is reasonably robust against framework changes. For this PR that means:
|
Having looked at my notes in #1 again, I just realized that if we go with the POST request approach, then using FileFetcher won't work, as it only has a URL parameter. Which means we either use I cannot recall running into this before. @malberts do you know of a place where we solved making POST requests in MediaWiki testable? |
I'm not aware of any place where we're doing external requests (POST or otherwise) as part of our own code. |
c437d9f
to
4cfd8fe
Compare
4cfd8fe
to
92c7b68
Compare
Manual Test Evidence TEST_Sparql_issue.1.mp4 |
e727d1b
to
922a3bc
Compare
922a3bc
to
29137c1
Compare
7e1ed8e
to
f581c64
Compare
f581c64
to
cfda05c
Compare
For #1
integrated SPARQL Query; addresses SPARQL-issue#1